This repository was archived by the owner on Mar 11, 2025. It is now read-only.
token-cli: create transfer-fee-basis-points and transfer-fee-maximum-fee flags #7053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hrushi20 <[email protected]>
Signed-off-by: Hrushi20 <[email protected]> remove unwanted space Signed-off-by: Hrushi20 <[email protected]> added missing comma Signed-off-by: Hrushi20 <[email protected]>
Hrushi20
force-pushed
the
feature-set-transfer-fee
branch
from
9058afe to
b693738
Compare
Contributor
Author
|
Do I add a test for |
joncinque
reviewed
Jul 31, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for the contribution, it looks good overall! Mostly some stylistic comments.
Also, can you run ./cargo-nightly fmt --all from the top of the repo? There's going to be some formatting issues when I run CI
joncinque
changed the title
Signed-off-by: Hrushi20 <[email protected]>
joncinque
reviewed
Jul 31, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
It looks like this is failing some of the clippy lints -- can you run ./cargo-nightly clippy -Zunstable-options --all-targets --features test-sbf -- --deny=warnings --deny=clippy::arithmetic_side_effects from the top of the repo and fix whatever's reported?
We're almost there!
Signed-off-by: Hrushi20 <[email protected]>
joncinque
approved these changes
Aug 1, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
transfer-feeinto two separate flags i.etransfer-fee-basis-pointsandtransfer-fee-maximum-fee. Add a message to deprecatetransfer-fee.Fixes #7020